Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of modified unsupported envoy version error into release/1.15.x #16524

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16518 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

  • When an envoy version is out of a supported range, we now return the envoy version being used as major.minor.x to indicate that it is the minor version at most that is incompatible
  • When an envoy version is in the list of unsupported envoy versions we return back the envoy version in the error message as major.minor.patch as now the exact version matters.

Note: Currently we do not have any envoy versions in the list of unsupported versions but we can support this in the future should the need arise to invalidate a particular major, minor or patch version

Testing & Reproduction steps

Verified error message with envoy out of bounds:

dc1svc2    | Envoy version 1.18.x is not supported. If there is a reason you need to use this version of envoy use the ignore-envoy-compatibility flag. Using an unsupported version of Envoy is not recommended and your experience may vary. For more information on compatibility see https://developer.hashicorp.com/consul/docs/connect/proxies/envoy#envoy-and-consul-client-agent

Verified error message with envoy in unsupported list:

dc1svc2    | Envoy version 1.18.3 is not supported. If there is a reason you need to use this version of envoy use the ignore-envoy-compatibility flag. Using an unsupported version of Envoy is not recommended and your experience may vary. For more information on compatibility see https://developer.hashicorp.com/consul/docs/connect/proxies/envoy#envoy-and-consul-client-agent

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/net-2984-adjust-envoy-compatibility-message/remotely-charmed-mastodon branch from 33405a6 to 5b5b359 Compare March 3, 2023 18:29
@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Mar 3, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit c07b931 into release/1.15.x Mar 3, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/mw/net-2984-adjust-envoy-compatibility-message/remotely-charmed-mastodon branch March 3, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants