Backport of Speed up test by registering services concurrently into release/1.15.x #16510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/kisunji/speed-up-dns-test/greatly-subtle-terrapin
branch
from
3fc960e
to
afdf093
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 2, 2023
kisunji
approved these changes
Mar 2, 2023
hc-github-team-consul-core
deleted the
backport/kisunji/speed-up-dns-test/greatly-subtle-terrapin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16509 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
TestDNS_TCP_and_UDP_Truncateis our longest running test averaging over 3m of runtime.The biggest bottleneck when profiling was the registration of 5000-10000 services at the start which is meant to cause DNS responses to be truncated.
The catalog registration is able to be run concurrently, reducing the runtime by magnitudes (3m10s -> 7s on my machine)
PR Checklist
Overview of commits