Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Fix rendering issue in search and lists into release/1.15.x #16446

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16444 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

Fixes the issue that was reported here.

Search filters were throwing errors and showing up empty. This also resulted in lists not showing full results until being interacted with. Weirdly enough I haven't been able to reproduce this against mock data despite the helper still being called on strings.

Before:
Running locally I tried logging the properties being passed into the "search across" filter and then logging them with the lowercase helper. They show up locally
Screenshot 2023-02-27 at 2 13 55 PM

When running it on the built version the lowercase is never logged as it errors out (I had the errors filtered here)
Screenshot 2023-02-27 at 2 14 25 PM

After
List and filter shows up properly and the lowercase is logged (I didn't commit the logs)
Screenshot 2023-02-27 at 2 39 56 PM

Testing & Reproduction steps

  1. Checkout 1.15.0 branch
  2. run make ui-docker to build the ui image
  3. run make dev-docker
  4. clone https://github.com/WenInCode/consul-setup
  5. in the consul-setup repo go to the setups/peering directory
  6. Apply the following patch to create more services
diff --git a/setups/peering/scripts/setup-peerings.mjs b/setups/peering/scripts/setup-peerings.mjs
index 8c7ab83..3d2c4ce 100644
--- a/setups/peering/scripts/setup-peerings.mjs
+++ b/setups/peering/scripts/setup-peerings.mjs
@@ -48,6 +48,12 @@ async function setupPeerings() {
 
       // setup a service that we will export
       await createService({ host: SERVER_1, name: "billing" });
+      await createService({ host: SERVER_1, name: "billing1" });
+      await createService({ host: SERVER_1, name: "billing2" });
+      await createService({ host: SERVER_1, name: "billing3" });
+      await createService({ host: SERVER_1, name: "billing4" });
+      await createService({ host: SERVER_1, name: "billing5" });
+      await createService({ host: SERVER_1, name: "billing6" });
 
       // export service via configuration entry
       await createConfigurationEntry({
  1. run docker-compose up
  2. run yarn setup:peerings
  3. Go to https://localhost:8501/ui
  4. Observe the services index page and interact with the filter

Now you can checkout this branch and repeat those steps to confirm the fix.

Links

CC-4383
#16429

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/fix/upgrade-ember-cli-string-helpers/widely-inviting-marmot branch from b341e27 to f3d992d Compare February 27, 2023 23:32
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/ui/fix/upgrade-ember-cli-string-helpers/widely-inviting-marmot branch from 3ad3538 to 332711d Compare February 27, 2023 23:32
@github-actions github-actions bot added the theme/ui Anything related to the UI label Feb 27, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 5af3774 into release/1.15.x Feb 27, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/ui/fix/upgrade-ember-cli-string-helpers/widely-inviting-marmot branch February 27, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants