Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix issue with peer services incorrectly appearing as connect-enabled. into release/1.15.x #16344

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16339 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Prior to this PR, all peer services were transmitted as connect-enabled as long as a one or more mesh-gateways were healthy. With this change, there is now a difference between typical services and connect services transmitted via peering.

A service will be reported as "connect-enabled" as long as any of these conditions are met:

  1. a connect-proxy sidecar is registered for the service name.
  2. a connect-native instance of the service is registered.
  3. a service resolver / splitter / router is registered for the service name.
  4. a terminating gateway has registered the service.

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/derekm/NET-1663/peer-connect-services/neatly-solid-dinosaur branch from 898b870 to e8a97cd Compare February 21, 2023 20:00
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 2604a03 into release/1.15.x Feb 21, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/derekm/NET-1663/peer-connect-services/neatly-solid-dinosaur branch February 21, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants