Backport of Fix hostname alignment checks for HTTPRoutes into release/1.15.x #16315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstucki
added
the
pr/no-changelog
3 tasks
sarahalsmiller
approved these changes
Feb 17, 2023
missylbytes
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is a manual backport from #16300
The below text is copied from the body of the original PR.
Description
This adds a missing hostname check between listeners and HTTPRoutes. Without it we do no verification of the alignment between route and Listener hostnames and the listener hostnames are essentially unused. In the upstream spec, only http routes that have hostnames matching the listener hostname (or no hostnames specified) can be bound to a listener. We accomplish this by filtering out routes (both in the xDS code and in our controller) based on the listener hostname and then checking to see if there are any valid hosts to bind to.
It's a stacked PR on top of the inline certs PR (#16295), so that should get merged first.
PR Checklist