Backport of troubleshoot: fixes and updated messages into release/1.15.x #16303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/troubleshoot-fixes/remarkably-together-humpback
branch
from
4d04553
to
6cd08b9
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Feb 17, 2023
malizz
force-pushed
the
backport/troubleshoot-fixes/remarkably-together-humpback
branch
from
4957af4
to
5c348b1
Compare
…ably-together-humpback
malizz
deleted the
backport/troubleshoot-fixes/remarkably-together-humpback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16294 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR makes a couple fixes, and updates all the output to be consistent across what's been discussed in the RFC. Note that this needs to be backported into 1.15.
Previously, it always printed
route ___ found, even when there isn't a route. Now it only says that if it actually is a case where a route should be found.In the below case, there are no routes and backendbloo does not have any instances. You can see there are no routes found in the below case (which is correct behavior) and the actions are displayed.
This also capitalizes the output, and makes the error messages more consistent and adds possible actions to most error cases.
Error case (deleted deployment for a peered upstream):
Success case (healthy upstream):
Output for
upstreams command:PR Checklist
Overview of commits