Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of add integration tests for troubleshoot into release/1.15.x #16261

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Backport of add integration tests for troubleshoot into release/1.15.x #16261

merged 2 commits into from
Feb 15, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16223 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

Description

  • add integration tests for troubleshoot command. (happy paths)
  • remove adminAddr from interface: only envoy proxies use this function

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/malizz/NET-1983/add-integration-tests/easily-crack-possum branch from c3fcc26 to fca0a63 Compare February 14, 2023 22:22
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/malizz/NET-1983/add-integration-tests/easily-crack-possum branch from fca0a63 to c3fcc26 Compare February 14, 2023 22:22
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Feb 14, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@malizz malizz marked this pull request as ready for review February 15, 2023 16:11
@malizz malizz merged commit 1d994d7 into release/1.15.x Feb 15, 2023
@malizz malizz deleted the backport/malizz/NET-1983/add-integration-tests/easily-crack-possum branch February 15, 2023 16:11
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@malizz malizz Awaiting requested review from malizz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @malizz