-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-memdb to fix a goroutine leak #15068
Conversation
Seems like go-tests is failing even on rerun 👀 |
Checking now. Looks unrelated to the bugfix so I'll bisect the previous version too (v1.3.3) |
Confirming that the tests are failing at 1.3.3. May be that some indexer behaviors got changed |
@@ -226,7 +226,7 @@ func testIndexerTableGatewayServices() map[string]indexerTestCase { | |||
Service: structs.ServiceName{Name: "SerVice"}, | |||
Port: 50123, | |||
} | |||
encodedPort := string([]byte{0x96, 0x8f, 0x06, 0, 0, 0, 0, 0, 0, 0}) | |||
encodedPort := string([]byte{0x80, 0, 0, 0, 0, 0, 0xc3, 0xcb}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way integers were encoded was updated in go-memdb@v1.3.3 by hashicorp/go-memdb#114
7114708
to
13d8f41
Compare
go-memdb was updated in v1.3.3 to make integers in indexes sortable, which changed how integers were encoded.
13d8f41
to
a7ea261
Compare
Description
go-memdb was updated to fix a goroutine leak: hashicorp/go-memdb#128
Fixes #15010