Support RFC 2782 SRV lookups for prepared queries #14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkirschner-hashicorp
force-pushed
the
dns-prepared-query-rfc-2782-lookup
branch
from
1df3610
to
90602ff
Compare
jkirschner-hashicorp
changed the title
boruszak
approved these changes
Sep 6, 2022
|
|
||
| The `datacenter` is optional, and if not provided, the datacenter of this Consul | ||
| agent is assumed. | ||
|
|
||
| The `query or name` is the ID or given name of an existing | ||
| The `query name or id` is the ID or given name of an existing |
There was a problem hiding this comment.
Suggested change
| The `query name or id` is the ID or given name of an existing | |
| The `query name or id` is the given name or ID of an existing |
Matching the order of fields/what they refer to.
huikang
approved these changes
Oct 21, 2022
jkirschner-hashicorp
added
the
type/docs
Format: _<query id or name>._tcp.query[.<datacenter>].<domain>
jkirschner-hashicorp
force-pushed
the
dns-prepared-query-rfc-2782-lookup
branch
from
90602ff
to
175489c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14143
Supported prepared query DNS lookups:
<query id or name>.query[.<datacenter>].<domain>_<query id or name>._tcp.query[.<datacenter>].<domain>Testing
Refer to included unit test changes