Prune old expired intermediate certs when appending a new one #14429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
force-pushed
the
ca-prune-intermediates
branch
from
0a0aa1f
to
7150cca
Compare
erichaberkorn
approved these changes
Sep 2, 2022
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some CA logic to prune old expired intermediate certs from the active root when a new intermediate is fetched. Since we renew the intermediate 1/3-1/2 of the way through its lifetime, this means there should never be more than a few old intermediates left around the root CA regardless of the configured root cert TTL.
Fixes #14159