-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a rate limiter to config auto-reload #12490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to create events.
* tidy ups * Add tests for inode reconcile
… the handler if success
rboyer
reviewed
Apr 1, 2022
rboyer
reviewed
Apr 1, 2022
rboyer
reviewed
Apr 1, 2022
rboyer
reviewed
Apr 1, 2022
rboyer
reviewed
Apr 1, 2022
rboyer
reviewed
Apr 1, 2022
Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>
kisunji
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Small nits
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/622677. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a coalesce timer to auto config reload to reduce the risk that we reload incomplete configuration or DDOS Consul by modifying the config file.
The coalesce timer is implemented as a Watcher interface that wrap the original file watcher.