Send success metric before modifying config

hashicorp · Aug 1, 2023 · ca12e89 · ca12e89
1 parent 7ea6280
commit ca12e89
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/agent/hcp/telemetry_provider.go b/agent/hcp/telemetry_provider.go
@@ -120,15 +120,16 @@ func (h *hcpProviderImpl) getUpdate(ctx context.Context) *dynamicConfig {
 		Labels:          telemetryCfg.MetricsConfig.Labels,
 		RefreshInterval: newRefreshInterval,
 	}
+	// Success metric must be recorded before acquiring write lock.
+	// This will be registered in the OTELSink, which tries to get a read lock.
+	metrics.IncrCounter(internalMetricRefreshSuccess, 1)
 
 	// Acquire write lock to update new configuration.
 	h.rw.Lock()
 	defer h.rw.Unlock()
 
 	h.cfg = newDynamicConfig
 
-	metrics.IncrCounter(internalMetricRefreshSuccess, 1)
-
 	return newDynamicConfig
 }