Skip to content

Commit

Permalink
ui: Ensure routing tab is shown when connect enabled (#8209)
Browse files Browse the repository at this point in the history
In #8065 we attempted to reduce
the amount of times that the UI requests the discovery chain endpoint
when connect is disabled on a datacenter.

Currently we can only tell if connect is disabled on a datacenter by
detecting a 500 error from a connect related endpoint.

In the above PR we mistakenly returned from a catch instead of
rethrowing the error, which meant that when a none 500 error was caught
the discovery chain data would be removed. Whilst at first glance this
doens't seem like a big problem due to the endpoint erroring, but we
also receive a 0 error when we abort endpoints during blocking queries.
This means that in certain cases we can remove cached data for the
discovery chain and then delay reloading it via a blocking query.

This PR replaces the return with a throw, which means that everything is
dealt with correctly via the blocking query error detection/logic.
  • Loading branch information
johncowen authored Jul 1, 2020
1 parent b287ebc commit 07b49f8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui-v2/app/services/repository/discovery-chain.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default RepositoryService.extend({
}
return;
default:
return;
throw e;
}
});
},
Expand Down

0 comments on commit 07b49f8

Please sign in to comment.