Skip to content

Conversation

anandmukul93
Copy link
Contributor

Changes proposed in this PR

How I've tested this PR

How I expect reviewers to test this PR

Checklist

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

…ups (#4757)

* fixes :
- token watcher returns err on more conditions
- directory watcher returns err on some more conditions and continues in case of recoverable cases
- cleanup files like cni-binary
- watch and recreate cni-binary & cni-host-token if applicable
- kill watchers before cleanup to avoid race condition updates on config files
- handle sigCh commonly for all watchers
- prevent breaking out of watchers

* final commit

* consul test setup

* All tests fixed

* race condition fix

* race condition while removing CNI fix

* fix remove multiple plugins of consul-cni if present

* fixing bin watcher

* testing binary race condition fix

* miss of a race condition return

* fix race condition

* fixed race conditions with older versions where no cleanup was done for binary

* changelog commit

* race condition wait group outside goroutine

* run workflows

* run tests with new concurrency group

* PR comments fixed

* fix test for acceptance
* granularity of package level concurrency

* test-status-reporting commit with k8s-workflow

* uniqueness group for old workflow shutdown at level of same pr

* input params fix to dispatch

* dispatch fix

* group fix for differnt groups

* change dispatch to main as workflows PR is merged

* bypass tests for unblocking others

* test force pass

* revert force checks pass

* dispatch context fix to one branch

* pr ref caused build failures when / is present causing dispatched workflow failures
@anandmukul93 anandmukul93 requested a review from a team as a code owner September 24, 2025 12:28
@anandmukul93 anandmukul93 changed the base branch from main to release/1.8.x September 24, 2025 12:28
@anandmukul93 anandmukul93 added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label and removed pr/no-backport signals that a PR will not contain a backport label labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant