fix (ldap): fix slice append to be concurrent safe#167
Merged
Conversation
jimlambrt
force-pushed
the
jimlambrt-search-warning-race
branch
2 times, most recently
from
bd26abf to
d2be0ad
Compare
johanbrandhorst
approved these changes
Sep 10, 2025
Contributor
johanbrandhorst
left a comment
johanbrandhorst
left a comment
There was a problem hiding this comment.
Just a style suggestion in the tests, LGTM!
When searching for groups, ensure the warnings slice is appended to in a concurrent safe manner.
jimlambrt
force-pushed
the
jimlambrt-search-warning-race
branch
from
d2be0ad to
40c1c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching for groups, ensure the warnings
slice is appended to in a concurrent safe manner.
PCI review checklist