Skip to content

Conversation

@lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Dec 16, 2025

Description

The only time a worker filter field should be labeled required for DHC is for AWS DHC in HCP env and using assume role (dynamic creds). All other cases worker-filter field is optional. (Worker filter is an enterprise/hcp only feature). Azure DHC were missing the worker-filter field so this PR adds that.

Screenshots (if appropriate)

image

How to Test

  1. Go to "Host Catalogs"
  2. Click "New Host Catalog"
  3. Validate worker filter is required only for AWS DHC using assume role in HCP env.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boundary-ui Ready Ready Preview, Comment Dec 16, 2025 11:09pm
boundary-ui-desktop Ready Ready Preview, Comment Dec 16, 2025 11:09pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants