chore: 🤖 upgrade got package to solve vulnerability #2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
calcaide
approved these changes
Jun 13, 2025
ZedLi
reviewed
Jun 13, 2025
| @@ -48,7 +48,8 @@ | |||
| "node-gyp": "^10.0.0", | |||
| "ansi-html": "^0.0.9", | |||
| "fireworm>async": "^2.6.4", | |||
| "ember-cli-babel>@babel/runtime": "7.27.6" | |||
| "ember-cli-babel>@babel/runtime": "7.27.6", | |||
| "package-json>got": "^14.4.7" | |||
There was a problem hiding this comment.
Should we have just overriden package-json to 10+ instead since it looks like they stop using got?
There was a problem hiding this comment.
good point, upgrading package-json is cleaner solution.
also, i am attempting to run ember try in the addons that use it and i am getting an error (same error on main) im going to look into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency tree:
got@9.6.0->package-json@6.5.0->ember-try-config@4.0.0(encoding@0.1.13)->ember-try@3.0.0(encoding@0.1.13)Attempting to upgrade ember-try did not cause
gotto update to a non-vulnerable version.ember-try-configis also already at newest released version andpackage-jsononly goes up to 6.5 for v6. Therefore, as a last resort we forcegotto resolve to newest, non-vulnerable version.Resolves alert #184
How to Test
Desktop release test run
Checklist