Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds EC2 Metadata Service endpoint and endpoint mode configuration #92

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Adds EC2 Metadata Service endpoint and endpoint mode configuration #92

merged 6 commits into from
Jan 31, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jan 29, 2022 •
edited
Loading

Adds the parameters EC2MetadataServiceEndpoint and EC2MetadataServiceEndpointMode as well as validating support via environment variable and shared configuration file

Closes #89
Closes #90
Closes #60

Builds on #91

@gdavison gdavison requested a review from a team as a code owner January 29, 2022 23:09
@ewbankkit
Copy link
Contributor

Do you need to update CHANGELOG.md?

ewbankkit
ewbankkit approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok  	github.com/hashicorp/aws-sdk-go-base/v2	6.148s

@gdavison
Copy link
Contributor Author

#94

@gdavison gdavison merged commit 9475e8a into v2 Jan 31, 2022
@gdavison gdavison deleted the fix-metadata-endpoint branch January 31, 2022 18:54
This was referenced Feb 2, 2022
Closed
Closed
Closed
This was referenced Feb 10, 2022
Closed
Closed
@md5 md5 mentioned this pull request Aug 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit