-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation with AWS SDK for Go v2 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, cannot reproduce the |
ewbankkit
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make test
go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go-v2 v1.8.0
go: downloading github.com/aws/aws-sdk-go-v2/config v1.6.0
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.4.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.6.1
go: downloading github.com/gdavison/aws-sdk-go-v2/credentials v1.2.2-0.20210811194025-146c1ad6c3b2
go: downloading github.com/aws/smithy-go v1.7.0
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.2.2
go: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.2.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.3.2
ok github.com/hashicorp/aws-sdk-go-base 0.864s
? github.com/hashicorp/aws-sdk-go-base/awsmocks [no test files]
ok github.com/hashicorp/aws-sdk-go-base/awsv1shim 9.499s
ok github.com/hashicorp/aws-sdk-go-base/tfawserr 2.287s
I have no go.mod
conflicts either.
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work on using AWS SDK for Go v2 instead of v1.
Authentication is incomplete:
AWS_PROFILE
with default shared credentials file does not workAWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
does workNote: when using this module, you will need to add the following to your
go.mod
file: