Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock and verify Web Identity Token support (STS AssumeRoleWithWebIdentity) #41

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Mock and verify Web Identity Token support (STS AssumeRoleWithWebIdentity) #41

merged 1 commit into from
Jun 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #33

Add a mock STS AssumeRoleWithWebIdentity valid response, add helper flag to TestGetSession() to enable web identity token support (via its bespoke environment variables), and verify we get the proper credentials when that support is enabled.

@bflad bflad added the tests label Jun 3, 2020
@bflad bflad added this to the v0.5.0 milestone Jun 3, 2020
@bflad bflad requested a review from a team June 3, 2020 00:34
gdavison
gdavison approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit 54bff5e into master Jun 3, 2020
@bflad bflad deleted the t-web-identity-testing branch June 3, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Verify Web Identity Token / EKS IAM Role Service Account (IRSA) via GetSession() Testing
2 participants
@bflad @gdavison