Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements tests for custom CA bundle support in shared configuration files #226

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Implements tests for custom CA bundle support in shared configuration files #226

merged 4 commits into from
Apr 6, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Apr 6, 2022 •
edited
Loading

The AWS SDK for Go v2 has added support for custom CA bundles in the shared configuration files.

Closes #148

@gdavison gdavison requested a review from a team as a code owner April 6, 2022 00:29
@gdavison gdavison marked this pull request as draft April 6, 2022 00:41
@gdavison gdavison marked this pull request as ready for review April 6, 2022 21:10
ewbankkit
ewbankkit approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok  	github.com/hashicorp/aws-sdk-go-base/v2	0.635s

@gdavison gdavison merged commit 0a3c8d5 into main Apr 6, 2022
gdavison added a commit that referenced this pull request Apr 6, 2022
@gdavison
Updates CHANGELOG for #226
e036f82
@gdavison gdavison deleted the config-updates branch April 12, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configuration: Set custom CA bundle from shared config or credentials files
2 participants
@gdavison @ewbankkit