Draft
Conversation
Collaborator
Author
|
I haven't reviewed every file yet, but I thought I'd push partial work. |
stmharry
reviewed
May 5, 2023
Contributor
stmharry
left a comment
stmharry
left a comment
There was a problem hiding this comment.
Some comments. More to come
|
|
||
| ;; this is very clever | ||
| ;; I wonder if it makes sense to have "profiles" like rust does, so we can get debug messages | ||
| ;; back from asserts in DEBUG mode, but have them stripped out for RELEASE mode |
Contributor
There was a problem hiding this comment.
I agree. We can have two includes: (include cypher.clib) and (include cypher@dev.clib)
| (defconstant cypher.constants.CONS #c) | ||
| (defconstant cypher.constants.FIRST #f) | ||
| (defconstant cypher.constants.REST #r) | ||
| (defconstant cypher.constants.LISTP #l) ;; the `#` emphasizes that it's a keyword |
Contributor
There was a problem hiding this comment.
Oh so #c is identical to plain c?
|
|
||
| ( | ||
| ; name mingling to be compatible with curry-and-treehash.clinc | ||
| ; name mangling to be compatible with curry-and-treehash.clinc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and notes to self. Do not merge this PR; it's for discussion purposes only.