feat: block node commands with state management#379
Open
leninmehedy wants to merge 17 commits intomainfrom
Open
feat: block node commands with state management#379leninmehedy wants to merge 17 commits intomainfrom
leninmehedy wants to merge 17 commits intomainfrom
Conversation
a8b9856 to
33c9dca
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com> # Conflicts: # cmd/weaver/commands/block/node/install.go # cmd/weaver/commands/common/flags.go # internal/core/paths.go # internal/workflows/blocknode.go # Conflicts: # internal/alloy/manifest.go # internal/alloy/render.go # internal/alloy/render_test.go
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
33c9dca to
033c456
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
033c456 to
be8801d
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
5d9eca1 to
1c4c4a1
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
1c4c4a1 to
1edf2f6
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
1edf2f6 to
615d1b0
Compare
Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the Hedera Block Node CLI commands shifting from direct workflow execution to using a business logic layer (
bll) for intent handling. Additionally, configuration types are migrated from theconfigpackage to thecorepackage for better organization.Refactoring command execution and configuration management:
initializeDependenciesandprepareUserInputsfunctions incmd/weaver/commands/block/node/init.goto centralize dependency initialization and user input validation, improving code reuse and maintainability.install,reset, andupgradecommands to use the new dependency and input preparation functions, and to delegate intent handling to the business logic layer viabll.BlockNode().HandleIntent, replacing direct workflow execution. [1] [2]Configuration and type organization:
BlockNodeConfig,BlockNodeStorage,AlloyConfig, andAlloyRemoteConfigfrom theconfigpackage to thecorepackage, updating all references accordingly for improved code organization. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Variable management:
flagProfileandflagForcevariables to package-level scope incmd/weaver/commands/block/node/node.goto facilitate their use across the new helper functions.Related Issues