Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pureChecks for file handler classes #9921

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Implement pureChecks for file handler classes #9921

merged 5 commits into from
Nov 16, 2023

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Nov 16, 2023

Description:
Implement pureChecks for file handler classes.

Related issue(s):

Fixes #9893

@kimbor
Implement pureChecks for file handler classes
ef00779 
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor self-assigned this Nov 16, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

Node: Unit Test Results

    2 281 files  ±0      2 281 suites  ±0   1h 25m 48s ⏱️ - 3m 55s
118 349 tests ±0  118 315 ✔️ ±0  34 💤 ±0  0 ❌ ±0 
126 667 runs  ±0  126 633 ✔️ ±0  34 💤 ±0  0 ❌ ±0 

Results for commit 059e8b7. ± Comparison against base commit a394b31.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   21m 40s ⏱️ + 21m 40s
312 tests +311  312 ✔️ +312  0 💤 ±0  0 ❌  - 1 
334 runs  +333  334 ✔️ +334  0 💤 ±0  0 ❌  - 1 

Results for commit 059e8b7. ± Comparison against base commit a394b31.

This pull request removes 1 and adds 312 tests. Note that renamed tests count towards both. 
EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   27m 55s ⏱️ -44s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 059e8b7. ± Comparison against base commit a394b31.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

Node: HAPI Test Results

1 246 tests  ±0   891 ✔️ ±0   1h 25m 11s ⏱️ -40s
   166 suites ±0   354 💤 ±0 
   166 files   ±0       1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 059e8b7. ± Comparison against base commit a394b31.

♻️ This comment has been updated with latest results.

@kimbor
Fix unit test
4742555 
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor marked this pull request as ready for review November 16, 2023 15:18
@kimbor kimbor requested a review from a team November 16, 2023 15:18
@kimbor kimbor requested a review from a team as a code owner November 16, 2023 15:18
jsync-swirlds
jsync-swirlds previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one suggestion.

povolev15
povolev15 previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe just Joseph suggestion but it is up to you

@kimbor
Added one more check in FileAppend pureChecks
5994d96 
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor dismissed stale reviews from povolev15 and jsync-swirlds via 5994d96 November 16, 2023 18:59
iwsimon
iwsimon previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimbor kimbor merged commit d3576d7 into develop Nov 16, 2023
10 of 13 checks passed
@kimbor kimbor deleted the 09893-pureChecks-for-file-handlers branch November 16, 2023 22:03
nickpoorman pushed a commit that referenced this pull request Nov 22, 2023
@kimbor @nickpoorman
Implement pureChecks for file handler classes (#9921)
8ada67a 
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwsimon iwsimon iwsimon approved these changes

@jsync-swirlds jsync-swirlds jsync-swirlds approved these changes

@povolev15 povolev15 povolev15 left review comments

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli

Assignees

@kimbor kimbor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement pureChecks for File handlers
4 participants
@kimbor @povolev15 @jsync-swirlds @iwsimon