[release/0.42] Remove unrecognized properties from testnet bootstrap and application config files #9208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
mhess-swl
requested review from
rbair23,
dalvizu,
poulok,
netopyr,
Nana-EC,
SimiHunjan,
steven-sheehy,
nickpoorman and
nathanklick
as code owners
ElijahLynn
reviewed
Oct 11, 2023
dalvizu
previously approved these changes
Oct 11, 2023
|
Is this accurate to add to the PR description?
|
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.42 #9208 +/- ##
===================================================
+ Coverage 68.46% 87.03% +18.56%
+ Complexity 25873 20504 -5369
===================================================
Files 2380 1636 -744
Lines 152985 63832 -89153
Branches 9568 6809 -2759
===================================================
- Hits 104740 55554 -49186
+ Misses 46145 6760 -39385
+ Partials 2100 1518 -582 ☔ View full report in Codecov by Sentry. |
ElijahLynn
approved these changes
Oct 11, 2023
ElijahLynn
changed the title
nathanklick
approved these changes
Oct 11, 2023
dalvizu
approved these changes
Oct 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Oct 11, 2023
|
There's nothing we can do about the failing Snyk check. Mitigation would require a netty upgrade, which we can't do, so I'll merge despite the fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
0.42.4tag threw the following error when starting in testnet:This PR fixes this issue by removing the errant properties from testnet's
bootstrap.propertiesandapplication.propertiesconfig files.These properties were removed in a 0.41.x release, but they are still in file 121 on testnet, and got accidentally copied to 0.42.
Additional related PRs: