Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync configs from file 121 in the bootstrap.properties and application.properties for testnet & mainnet #9055

Merged
merged 11 commits into from
Oct 5, 2023
Merged

Sync configs from file 121 in the bootstrap.properties and application.properties for testnet & mainnet #9055

merged 11 commits into from
Oct 5, 2023

Conversation

Neeharika-Sompalli
Copy link
Member

Sync configs from file 121 in the bootstrap.properties

@Neeharika-Sompalli
fix configuration for mainnet and testnet bootstrap.properties and ap…
4380907 
…plication.properties

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Oct 5, 2023
Neeharika-Sompalli and others added 3 commits October 5, 2023 13:30
@Neeharika-Sompalli @ElijahLynn
Update hedera-node/configuration/mainnet/bootstrap.properties
8de33d3 
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
@Neeharika-Sompalli @ElijahLynn
Update hedera-node/configuration/mainnet/application.properties
33d9203 
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
@Neeharika-Sompalli
update comments on files as per review
636887a 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli changed the title Sync configs from file 121 in the bootstrap.properties Sync configs from file 121 in the bootstrap.properties and application.properties Oct 5, 2023
@ElijahLynn ElijahLynn changed the title Sync configs from file 121 in the bootstrap.properties and application.properties Sync configs from file 121 in the bootstrap.properties and application.properties for testnet & mainnet Oct 5, 2023
@Neeharika-Sompalli
keep back existing testnet configs
4c355f2 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli
more comment changes
17d5362 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli
add an empty line at the end
39df7ba 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli
remove unused properties and add ledger.id and chain.id to mainnet pr…
6d9c133 
…operties files to be similar to testnet files

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Node: Unit Test Results

    2 229 files      2 229 suites   1h 7m 2s ⏱️
118 081 tests 118 046 ✔️ 35 💤 0 ❌
126 372 runs  126 337 ✔️ 35 💤 0 ❌

Results for commit 8f654f8.

♻️ This comment has been updated with latest results.

@Neeharika-Sompalli
comments
9c14c7b 
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Neeharika-Sompalli and others added 2 commits October 5, 2023 14:47
@Neeharika-Sompalli @ElijahLynn
Update hedera-node/configuration/mainnet/application.properties
11ffa76 
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
@Neeharika-Sompalli @ElijahLynn
Update hedera-node/configuration/mainnet/bootstrap.properties
8f654f8 
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Node: E2E Test Results

    1 files      1 suites   22m 31s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit 8f654f8.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Node: Integration Test Results

278 tests   278 ✔️  32m 17s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 8f654f8.

ElijahLynn
ElijahLynn approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ElijahLynn ElijahLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of devops. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Node: HAPI Test Results

1 182 tests   517 ✔️  51m 38s ⏱️
   156 suites  663 💤
   156 files        2 ❌

Results for commit 8f654f8.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Neeharika-Sompalli Neeharika-Sompalli merged commit 83994dc into develop Oct 5, 2023
@Neeharika-Sompalli Neeharika-Sompalli deleted the sync-bootstrap-properties-dev branch October 5, 2023 23:44
Neeharika-Sompalli added a commit that referenced this pull request Oct 5, 2023
@Neeharika-Sompalli @ElijahLynn
Sync configs from file 121 in the bootstrap.properties and `applica…
d03b713 
…tion.properties` for testnet & mainnet (#9055)

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli mentioned this pull request Oct 5, 2023
Merged
Neeharika-Sompalli added a commit that referenced this pull request Oct 5, 2023
@Neeharika-Sompalli @ElijahLynn
Sync configs from file 121 in the bootstrap.properties and `applica…
446f529 
…tion.properties` for testnet & mainnet (#9055)

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Co-authored-by: Elijah Lynn <elijah@elijahlynn.net>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
This was referenced Oct 5, 2023
Merged
Merged
@mhess-swl mhess-swl mentioned this pull request Oct 9, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElijahLynn ElijahLynn ElijahLynn approved these changes

@rbair23 rbair23 rbair23 approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu

@poulok poulok Awaiting requested review from poulok

@netopyr netopyr Awaiting requested review from netopyr

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@steven-sheehy steven-sheehy Awaiting requested review from steven-sheehy

@nickpoorman nickpoorman Awaiting requested review from nickpoorman

@nathanklick nathanklick Awaiting requested review from nathanklick

@tinker-michaelj tinker-michaelj Awaiting requested review from tinker-michaelj

@tannerjfco tannerjfco Awaiting requested review from tannerjfco

Assignees

@Neeharika-Sompalli Neeharika-Sompalli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neeharika-Sompalli @ElijahLynn @rbair23 @netopyr