Fix createContractWithStakingFields()
#8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Neeharika-Sompalli
previously approved these changes
Oct 2, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8986 +/- ##
==========================================
Coverage ? 65.09%
Complexity ? 29242
==========================================
Files ? 3225
Lines ? 122854
Branches ? 12603
==========================================
Hits ? 79972
Misses ? 39912
Partials ? 2970 ☔ View full report in Codecov by Sentry. |
Nana-EC
previously approved these changes
Oct 2, 2023
mhess-swl
previously approved these changes
Oct 2, 2023
.../java/com/hedera/node/app/service/token/impl/handlers/staking/StakingRewardsHandlerImpl.java
Outdated
Show resolved
Hide resolved
kimbor
previously approved these changes
Oct 3, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
tinker-michaelj
dismissed stale reviews from iwsimon, kimbor, mhess-swl, and Nana-EC
via
a896ba5
iwsimon
previously approved these changes
Oct 3, 2023
mhess-swl
previously approved these changes
Oct 3, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Oct 3, 2023
mhess-swl
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ContractCreatetransactions #8719createContractWithStakingFields()spec was that a_TO_ACCOUNTstake change scenario would cause aConcurrentModificationExceptionin theforloop here, since the logic inside the loop would add the "stakee" account to the modified set---and cause the iterator to detect a concurrent modification.