Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for deleted accounts in crypto allowances #8834

Merged
merged 11 commits into from
Oct 3, 2023
Merged

Check for deleted accounts in crypto allowances #8834

merged 11 commits into from
Oct 3, 2023

Conversation

mhess-swl
Copy link
Member

Part of #8465

@mhess-swl
Check for deleted accounts in crypto allowances
3cf5a82 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl added Hedera Token Service Issues related to the Hedera Token Service. Modularization Issues or PRs related to modularization labels Sep 22, 2023
@mhess-swl mhess-swl added this to the v0.43 milestone Sep 22, 2023
@mhess-swl mhess-swl self-assigned this Sep 22, 2023
@mhess-swl mhess-swl requested a review from a team September 22, 2023 16:02
@mhess-swl mhess-swl requested a review from a team as a code owner September 22, 2023 16:02
@mhess-swl
Add missing 'final'
bb9cb0b 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
iwsimon
iwsimon previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhess-swl
Use existing validation method
606f631 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl requested a review from iwsimon September 22, 2023 16:20
iwsimon
iwsimon previously approved these changes Sep 22, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Node: Unit Test Results

    2 221 files      2 221 suites   1h 26m 6s ⏱️
118 024 tests 117 989 ✔️ 35 💤 0 ❌
126 315 runs  126 280 ✔️ 35 💤 0 ❌

Results for commit 4963338.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@15d08b0). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #8834   +/-   ##
==========================================
  Coverage           ?   65.09%           
  Complexity         ?    29239           
==========================================
  Files              ?     3225           
  Lines              ?   122854           
  Branches           ?    12601           
==========================================
  Hits               ?    79975           
  Misses             ?    39902           
  Partials           ?     2977

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   18m 43s ⏱️
310 tests 310 ✔️ 0 💤 0 ❌
328 runs  328 ✔️ 0 💤 0 ❌

Results for commit 4963338.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Node: HAPI Test Results

1 180 tests   427 ✔️  30m 41s ⏱️
   156 suites  753 💤
   156 files        0 ❌

Results for commit 4963338.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

Node: Integration Test Results

278 tests   278 ✔️  32m 37s ⏱️
    5 suites      0 💤
    5 files        0 ❌

Results for commit 4963338.

♻️ This comment has been updated with latest results.

@mhess-swl
Fix more delete allowance suite tests
8f46885 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
iwsimon
iwsimon previously approved these changes Sep 22, 2023
View reviewed changes
@mhess-swl
rename variable
b37fddc 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl
Don't add redundant payer to keys
50fcd90 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl
Fix aggregation of nft delete allowances
cf0ace6 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
iwsimon
iwsimon previously approved these changes Sep 22, 2023
View reviewed changes
@mhess-swl
Fix broken approve allowance tests
bdec6d8 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Neeharika-Sompalli
Neeharika-Sompalli reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems one HAPI test is failing to be fixed

iwsimon
iwsimon previously approved these changes Sep 25, 2023
View reviewed changes
@mhess-swl mhess-swl linked an issue Oct 2, 2023 that may be closed by this pull request
Test CryptoTransferSuite #8466
Closed
22 tasks
@mhess-swl mhess-swl removed a link to an issue Oct 2, 2023
Test CryptoTransferSuite #8466
Closed
22 tasks
@mhess-swl mhess-swl linked an issue Oct 2, 2023 that may be closed by this pull request
Start testing CryptoDeleteAllowanceSuite #8465
Closed
@mhess-swl
Merge branch 'develop' into 08465_effective-owner
4963338 
Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
@mhess-swl mhess-swl dismissed stale reviews from iwsimon and Neeharika-Sompalli via 4963338 October 2, 2023 22:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Neeharika-Sompalli
Neeharika-Sompalli approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @mhess-swl

iwsimon
iwsimon approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhess-swl mhess-swl merged commit e41f07e into develop Oct 3, 2023
@mhess-swl mhess-swl deleted the 08465_effective-owner branch October 3, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwsimon iwsimon iwsimon approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

Assignees

@mhess-swl mhess-swl

Labels
Hedera Token Service Issues related to the Hedera Token Service. Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
v0.43
Development

Successfully merging this pull request may close these issues.

Start testing CryptoDeleteAllowanceSuite
3 participants
@mhess-swl @Neeharika-Sompalli @iwsimon