Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use preferred headlong API when decoding RLP #17525

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

david-bakin-sl
Copy link
Member

Description:

Headlong's RLPItem.asBigInt preferred over asByte/asInt/asLong.

Related issue(s):

Fixes #17523

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Jan 23, 2025
@david-bakin-sl david-bakin-sl added this to the v0.59 milestone Jan 23, 2025
@david-bakin-sl david-bakin-sl self-assigned this Jan 23, 2025
@david-bakin-sl david-bakin-sl requested a review from a team as a code owner January 23, 2025 19:42
@david-bakin-sl david-bakin-sl requested a review from kimbor January 23, 2025 19:42
Copy link

codacy-production bot commented Jan 23, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b2c647) 98068 71447 72.85%
Head commit (4c95659) 98079 (+11) 71458 (+11) 72.86% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17525) 20 20 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@david-bakin-sl david-bakin-sl force-pushed the 17523-rlp-encoding-refactor branch from 9933cb4 to 27142cb Compare January 23, 2025 19:53
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (2b2c647) to head (4c95659).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...hedera/node/app/hapi/utils/ethereum/EthTxData.java 80.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17525      +/-   ##
============================================
- Coverage     68.94%   68.94%   -0.01%     
- Complexity    22757    22760       +3     
============================================
  Files          2619     2619              
  Lines         98285    98296      +11     
  Branches      10185    10189       +4     
============================================
+ Hits          67761    67768       +7     
  Misses        26687    26687              
- Partials       3837     3841       +4     
Files with missing lines Coverage Δ
...hedera/node/app/hapi/utils/ethereum/EthTxData.java 84.94% <80.00%> (-1.34%) ⬇️

Impacted file tree graph

lukelee-sl
lukelee-sl previously approved these changes Jan 23, 2025
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Headlong's `RLPItem.asBigInt` preferred over `asByte/asInt/asLong`.

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
@david-bakin-sl david-bakin-sl force-pushed the 17523-rlp-encoding-refactor branch from 74fc49a to 4c95659 Compare January 23, 2025 23:15
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@david-bakin-sl david-bakin-sl merged commit a1d2d0b into main Jan 24, 2025
46 checks passed
@david-bakin-sl david-bakin-sl deleted the 17523-rlp-encoding-refactor branch January 24, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use preferred headlong API when decoding RLP
3 participants