-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use preferred headlong API when decoding RLP #17525
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
9933cb4
to
27142cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17525 +/- ##
============================================
- Coverage 68.94% 68.94% -0.01%
- Complexity 22757 22760 +3
============================================
Files 2619 2619
Lines 98285 98296 +11
Branches 10185 10189 +4
============================================
+ Hits 67761 67768 +7
Misses 26687 26687
- Partials 3837 3841 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
27142cb
to
74fc49a
Compare
Headlong's `RLPItem.asBigInt` preferred over `asByte/asInt/asLong`. Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
74fc49a
to
4c95659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description:
Headlong's
RLPItem.asBigInt
preferred overasByte/asInt/asLong
.Related issue(s):
Fixes #17523
Checklist