Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move init logging to start of process #17355

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

edward-swirldslabs
Copy link
Contributor

Description:
This PR unifies the process of starting logging between Browser and ServicesMain, and starts logging at the beginning of the process for either entry point. The Node is Starting banner has been added to the initLogging method to show up as the first log message.

If all goes correctly, the Node is Starting banner is the first log entry in the swirlds.log on the JRS runs.

Related issue(s):

Fixes #16623

Signed-off-by: Edward Wertz <edward@swirldslabs.com>
@edward-swirldslabs edward-swirldslabs added this to the v0.59 milestone Jan 13, 2025
@edward-swirldslabs edward-swirldslabs self-assigned this Jan 13, 2025
@edward-swirldslabs edward-swirldslabs requested review from a team as code owners January 13, 2025 16:01
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.60%. Comparing base (f26286a) to head (a2dbccb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...atform/builder/internal/StaticPlatformBuilder.java 60.00% 4 Missing ⚠️
...re/src/main/java/com/swirlds/platform/Browser.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17355      +/-   ##
============================================
+ Coverage     67.58%   67.60%   +0.01%     
+ Complexity    22142    22141       -1     
============================================
  Files          2588     2588              
  Lines         96701    96689      -12     
  Branches      10099    10099              
============================================
+ Hits          65359    65362       +3     
+ Misses        27604    27584      -20     
- Partials       3738     3743       +5     
Files with missing lines Coverage Δ
...rc/main/java/com/hedera/node/app/ServicesMain.java 33.58% <100.00%> (+2.59%) ⬆️
...re/src/main/java/com/swirlds/platform/Browser.java 0.00% <0.00%> (ø)
...atform/builder/internal/StaticPlatformBuilder.java 26.66% <60.00%> (+26.66%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 58.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f26286a) 96484 68945 71.46%
Head commit (a2dbccb) 96472 (-12) 68953 (+8) 71.47% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17355) 12 7 58.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for services ✅

@edward-swirldslabs edward-swirldslabs merged commit 650d911 into main Jan 13, 2025
62 of 64 checks passed
@edward-swirldslabs edward-swirldslabs deleted the 16623-init-logging-at-start-of-process branch January 13, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform log did not work if platform exit immediately during restart
3 participants