Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable scheduleNative feature flag #17317

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

stoyanov-st
Copy link
Contributor

Description:

Enable the scheduleNative feature flag as the development is now done

Related issue(s):
#16964
Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.59 milestone Jan 10, 2025
@stoyanov-st stoyanov-st self-assigned this Jan 10, 2025
@stoyanov-st stoyanov-st requested a review from a team as a code owner January 10, 2025 15:39
@stoyanov-st stoyanov-st requested a review from kimbor January 10, 2025 15:39
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (032a2f6) 96191 68558 71.27%
Head commit (0a966a4) 96191 (+0) 68558 (+0) 71.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17317) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.41%. Comparing base (032a2f6) to head (0a966a4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17317   +/-   ##
=========================================
  Coverage     67.41%   67.41%           
- Complexity    22063    22064    +1     
=========================================
  Files          2585     2585           
  Lines         96408    96408           
  Branches      10071    10071           
=========================================
+ Hits          64992    64993    +1     
  Misses        27698    27698           
+ Partials       3718     3717    -1     
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @stoyanov-st

@stoyanov-st stoyanov-st merged commit df65db7 into main Jan 10, 2025
58 checks passed
@stoyanov-st stoyanov-st deleted the hip-756-enable-schedule-native-feature-flag branch January 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants