Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry-pick: Generated Files 101 & 102 Sequentially Ordered by Node ID #17289

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Jan 9, 2025

Signed-off-by: Iris Simon iris.simon@swirldslabs.com
(cherry picked from commit 66ebd29)
Cherry-pick PR #17253

Description:

Related issue(s):

Fixes #17067

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
(cherry picked from commit 66ebd29)
@iwsimon iwsimon added this to the v0.59 milestone Jan 9, 2025
@iwsimon iwsimon self-assigned this Jan 9, 2025
@iwsimon iwsimon requested review from a team as code owners January 9, 2025 17:24
@iwsimon iwsimon changed the title feat: cherry-pick: Generated Files 101 & 102 Sequentially Ordered by Node ID (#17253) feat: cherry-pick: Generated Files 101 & 102 Sequentially Ordered by Node ID Jan 9, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5f9fdff) 95769 65214 68.10%
Head commit (f20b1fb) 95770 (+1) 65217 (+3) 68.10% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17289) 21 21 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @iwsimon !

@steven-sheehy steven-sheehy modified the milestones: v0.59, v0.58 Jan 9, 2025
@iwsimon iwsimon merged commit b208f7c into release/0.58 Jan 9, 2025
64 of 65 checks passed
@iwsimon iwsimon deleted the 17253-cherry-pick branch January 9, 2025 19:28
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.34%. Comparing base (5f9fdff) to head (f20b1fb).
Report is 1 commits behind head on release/0.58.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.58   #17289   +/-   ##
===============================================
  Coverage           64.33%   64.34%           
- Complexity          20912    20914    +2     
===============================================
  Files                2549     2549           
  Lines               96006    96007    +1     
  Branches            10049    10047    -2     
===============================================
+ Hits                61769    61773    +4     
+ Misses              30600    30598    -2     
+ Partials             3637     3636    -1     
Files with missing lines Coverage Δ
...app/service/file/impl/schemas/V0490FileSchema.java 88.82% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants