Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance consistency testing tool #17136

Merged
merged 19 commits into from
Jan 13, 2025

Conversation

mustafauzunn
Copy link
Collaborator

Description:

Enhance the consistency testing tool to work with new transactions of bytes.

Related issue(s):

Fixes #16790

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn added the Platform Tickets pertaining to the platform label Dec 19, 2024
@mustafauzunn mustafauzunn added this to the v0.58 milestone Dec 19, 2024
@mustafauzunn mustafauzunn self-assigned this Dec 19, 2024
Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be1981d) 96191 68558 71.27%
Head commit (ee1eaab) 96208 (+17) 68633 (+75) 71.34% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17136) 18 15 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (be1981d) to head (ee1eaab).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../demo/consistency/ConsistencyTestingToolState.java 88.23% 2 Missing ⚠️
...s/demo/consistency/ConsistencyTestingToolMain.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17136      +/-   ##
============================================
+ Coverage     67.41%   67.47%   +0.06%     
- Complexity    22063    22080      +17     
============================================
  Files          2585     2585              
  Lines         96408    96425      +17     
  Branches      10071    10072       +1     
============================================
+ Hits          64992    65062      +70     
+ Misses        27698    27640      -58     
- Partials       3718     3723       +5     
Files with missing lines Coverage Δ
.../java/com/swirlds/platform/system/SwirldState.java 0.00% <ø> (ø)
...s/demo/consistency/ConsistencyTestingToolMain.java 0.00% <0.00%> (ø)
.../demo/consistency/ConsistencyTestingToolState.java 71.42% <88.23%> (+71.42%) ⬆️

Impacted file tree graph

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…com:hashgraph/hedera-services into 16790-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…com:hashgraph/hedera-services into 16790-enhance-consistency-testing-tool
@mustafauzunn mustafauzunn changed the base branch from develop to 16703-refactor-consumer-system-transactions December 20, 2024 11:39
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Base automatically changed from 16703-refactor-consumer-system-transactions to develop December 20, 2024 12:58
…6790-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/platform-apps/demos/CryptocurrencyDemo/src/main/java/com/swirlds/demo/crypto/CryptocurrencyDemoState.java
#	platform-sdk/platform-apps/demos/HelloSwirldDemo/src/main/java/com/swirlds/demo/hello/HelloSwirldDemoState.java
#	platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoState.java
#	platform-sdk/platform-apps/tests/AddressBookTestingTool/src/main/java/com/swirlds/demo/addressbook/AddressBookTestingToolState.java
#	platform-sdk/platform-apps/tests/ConsistencyTestingTool/src/main/java/com/swirlds/demo/consistency/ConsistencyTestingToolState.java
#	platform-sdk/platform-apps/tests/ISSTestingTool/src/main/java/com/swirlds/demo/iss/ISSTestingToolState.java
#	platform-sdk/platform-apps/tests/MigrationTestingTool/src/main/java/com/swirlds/demo/migration/MigrationTestingToolState.java
#	platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PlatformTestingToolState.java
#	platform-sdk/platform-apps/tests/StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/StatsSigningTestingToolState.java
#	platform-sdk/platform-apps/tests/StressTestingTool/src/main/java/com/swirlds/demo/stress/StressTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/PlatformMerkleStateRoot.java
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldState.java
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/turtle/runner/TurtleTestingToolState.java
#	platform-sdk/swirlds-platform-core/src/testFixtures/java/com/swirlds/platform/test/fixtures/state/BlockingSwirldState.java
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…0-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java
@mustafauzunn mustafauzunn marked this pull request as ready for review January 6, 2025 08:56
@mustafauzunn mustafauzunn requested review from a team as code owners January 6, 2025 08:56
andrewb1269hg
andrewb1269hg previously approved these changes Jan 6, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/ConsistencyTestingTool/build.gradle.kts

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
@mustafauzunn mustafauzunn modified the milestones: v0.58, v0.59 Jan 7, 2025
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
IvanKavaldzhiev
IvanKavaldzhiev previously approved these changes Jan 7, 2025
Copy link
Collaborator

@IvanKavaldzhiev IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewb1269hg
andrewb1269hg previously approved these changes Jan 9, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/ConsistencyTestingTool/build.gradle.kts

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…0-enhance-consistency-testing-tool

# Conflicts:
#	platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/system/SwirldMain.java
andrewb1269hg
andrewb1269hg previously approved these changes Jan 10, 2025
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve file platform-sdk/platform-apps/tests/ConsistencyTestingTool/build.gradle.kts

Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve platform-sdk/platform-apps/tests/ConsistencyTestingTool/build.gradle.kts

@mustafauzunn mustafauzunn requested review from lpetrovic05 and removed request for lpetrovic05 January 13, 2025 08:45
@mustafauzunn mustafauzunn merged commit 4f9e972 into main Jan 13, 2025
51 of 52 checks passed
@mustafauzunn mustafauzunn deleted the 16790-enhance-consistency-testing-tool branch January 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt ConsistencyTestingTool to work with new proto types and enhance README
4 participants