Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HIP-904 Additional e2e test cases where receiver contract and already associated #16399

Merged
merged 16 commits into from
Nov 21, 2024
Merged

fix: HIP-904 Additional e2e test cases where receiver contract and already associated #16399

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c7ccdf4
test: extract common logic and combine HRC904 solidity code
stoyanov-st Oct 29, 2024
f103919
refactor: extract common logic
stoyanov-st Oct 29, 2024
8b1c0c2
refactor: isSelectorIfConfigEnabled
stoyanov-st Oct 29, 2024
dd308e5
test: rework some unit tests
stoyanov-st Oct 29, 2024
bf9cd0a
test: include error messages
stoyanov-st Oct 29, 2024
e554bb2
test: e2e with receiver contract already associated
stoyanov-st Nov 4, 2024
4a1fb19
Merge branch 'refs/heads/develop' into 16214-refactor-hip-904
stoyanov-st Nov 7, 2024
612d224
fix: post merge artifacts
stoyanov-st Nov 7, 2024
f8be138
test: combine address preparing methods
stoyanov-st Nov 7, 2024
11a60dc
Merge branch 'refs/heads/16214-refactor-hip-904' into 15237-hip-904-e…
stoyanov-st Nov 7, 2024
f41da7e
test: combine address preparing methods
stoyanov-st Nov 7, 2024
e357b24
Merge branch 'refs/heads/develop' into 15237-hip-904-e2e-tests
stoyanov-st Nov 13, 2024
cc3d52b
Merge branch 'refs/heads/develop' into 15237-hip-904-e2e-tests
stoyanov-st Nov 14, 2024
ada4cbd
test: adjust tests with receiving contracts
stoyanov-st Nov 18, 2024
67c3f22
fix: disable negative test for airdrops to contracts
stoyanov-st Nov 18, 2024
e41b223
fix: address pr comments
stoyanov-st Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: include error messages 
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
  • Loading branch information
@stoyanov-st
stoyanov-st committed Oct 29, 2024
commit bf9cd0ac5d960eb35ed62ce15572828b0144676d
8 changes: 5 additions & 3 deletions ...service/contract/impl/test/exec/systemcontracts/hts/airdrops/TokenAirdropDecoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

package com.hedera.node.app.service.contract.impl.test.exec.systemcontracts.hts.airdrops;

import static com.hedera.hapi.node.base.ResponseCodeEnum.INVALID_RECEIVING_NODE_ACCOUNT;
import static com.hedera.hapi.node.base.ResponseCodeEnum.TOKEN_REFERENCE_LIST_SIZE_LIMIT_EXCEEDED;
import static com.hedera.node.app.service.contract.impl.exec.systemcontracts.hts.airdrops.TokenAirdropTranslator.TOKEN_AIRDROP;
import static com.hedera.node.app.service.contract.impl.test.TestHelpers.FUNGIBLE_TOKEN_HEADLONG_ADDRESS;
import static com.hedera.node.app.service.contract.impl.test.TestHelpers.FUNGIBLE_TOKEN_ID;
Expand Down Expand Up @@ -154,7 +156,7 @@ void tokenAirdropDecoderFailsIfReceiverIsSystemAcc() {
.willReturn(AccountID.newBuilder().accountNum(750).build());
assertThatExceptionOfType(HandleException.class)
.isThrownBy(() -> subject.decodeAirdrop(attempt))
.withMessage("");
.withMessage(INVALID_RECEIVING_NODE_ACCOUNT.protoName());
}

@Test
Expand Down Expand Up @@ -247,7 +249,7 @@ void tokenAirdropDecoderFailsIfAirdropExceedsLimits() {
given(ledgerConfig.nftTransfersMaxLen()).willReturn(10);
assertThatExceptionOfType(HandleException.class)
.isThrownBy(() -> subject.decodeAirdrop(attempt))
.withMessage("");
.withMessage(TOKEN_REFERENCE_LIST_SIZE_LIMIT_EXCEEDED.protoName());
}

@Test
Expand Down Expand Up @@ -297,6 +299,6 @@ void tokenAirdropDecoderForNFTFailsIfNftExceedLimits() {
given(ledgerConfig.nftTransfersMaxLen()).willReturn(10);
assertThatExceptionOfType(HandleException.class)
.isThrownBy(() -> subject.decodeAirdrop(attempt))
.withMessage("");
.withMessage(TOKEN_REFERENCE_LIST_SIZE_LIMIT_EXCEEDED.protoName());
}
}
Loading