-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP-1028 Implement Create and Update calls with metadata #16135
Conversation
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech> Co-authored-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will defer to @lukelee-sl or @tinker-michaelj review on smart contract files. Changes to other files LGTM! Thanks @stoyanov-st
Description:
!!! NOTE: This PR is squashed version of #15136 due to verification issues !!!
This PR aims to add the implementation for
CreateToken
andUpdateToken
system contract calls with the metadata field described in HIP-1028 included.Also provided E2E tests for validation of the newly added flows.
The feature is behind a feature flag
contracts.systemContract.metadataKeyAndFieldSupport.enabled
that is only enable on dev and previewnet envs.Related issue(s):
Fixes #14591 #15126 #14622 #15237
Notes for reviewer:
! In order to completely support
getInfo
function response types we need to have the System Contract versioning implemented so that we can expose new functions. Thus some of the calls for getInfo are commented for the current state.