Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use DAB upgrade test in CI runs #15618

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Neeharika-Sompalli
Copy link
Member

Use upgrade test that uses DAB transactions for deleting and updating node instead of the old way for upgrade

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (832428e) 109356 67520 61.74%
Head commit (6f77b66) 109356 (+0) 67520 (+0) 61.74% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15618) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.20%. Comparing base (832428e) to head (6f77b66).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15618   +/-   ##
==========================================
  Coverage      58.20%   58.20%           
  Complexity     21615    21615           
==========================================
  Files           2784     2784           
  Lines         109539   109539           
  Branches       11212    11212           
==========================================
  Hits           63754    63754           
  Misses         41909    41909           
  Partials        3876     3876           

Impacted file tree graph

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Neeharika-Sompalli

@rbarkerSL rbarkerSL changed the title test: Use DAB upgrade test in CI runs test: Use DAB upgrade test in CI runs Sep 30, 2024
@Neeharika-Sompalli Neeharika-Sompalli merged commit fd09f1f into develop Sep 30, 2024
67 of 77 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the use-dab-upgrade-test branch September 30, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants