feat: invalid query error handling #13900

kimbor · 2024-06-17T19:56:52Z

Description:
Improve error handling when a query contains an invalid parameter.

Related issue(s):
Fixes #13795

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

github-actions · 2024-06-17T20:13:34Z

Node: Unit Test Results

1 562 files 1 562 suites 1h 52m 7s ⏱️
111 850 tests 111 791 ✅ 59 💤 0 ❌
120 144 runs 120 085 ✅ 59 💤 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:14:16Z

Node: HAPI Test (Restart) Results

3 tests 3 ✅ 6m 21s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:14:50Z

Node: HAPI Test (Token) Results

20 files 20 suites 5m 54s ⏱️
265 tests 265 ✅ 0 💤 0 ❌
340 runs 340 ✅ 0 💤 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:15:18Z

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 5m 55s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

codecov · 2024-06-17T20:15:56Z

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (9973fae) to head (6099032).
Report is 55 commits behind head on develop.

❗ Current head 6099032 differs from pull request most recent head d7f60ad

Please upload reports for the commit d7f60ad to get more accurate results.

Files	Patch %	Lines
...ra/node/app/workflows/query/QueryWorkflowImpl.java	90.90%	2 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #13900      +/-   ##
=============================================
+ Coverage      67.58%   67.71%   +0.12%     
- Complexity     36486    36687     +201     
=============================================
  Files           3732     3762      +30     
  Lines         149767   149852      +85     
  Branches       15571    15571              
=============================================
+ Hits          101223   101469     +246     
+ Misses         44179    44043     -136     
+ Partials        4365     4340      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-17T20:19:15Z

Node: HAPI Test (Crypto) Results

24 files 24 suites 12m 15s ⏱️
361 tests 361 ✅ 0 💤 0 ❌
368 runs 368 ✅ 0 💤 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:29:54Z

Node: HAPI Test (Misc) Results

51 files 51 suites 23m 2s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs 375 ✅ 0 💤 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:30:22Z

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 23m 15s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

github-actions · 2024-06-17T20:30:34Z

Node: HAPI Test (Smart Contract) Results

72 files 72 suites 22m 38s ⏱️
616 tests 616 ✅ 0 💤 0 ❌
668 runs 668 ✅ 0 💤 0 ❌

Results for commit d7f60ad.

♻️ This comment has been updated with latest results.

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

netopyr

We should discuss the solution. If we cannot parse the query, we should not send an arbitrary response type (TransactionGetReceiptResponse).

hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/query/QueryWorkflowImpl.java

…id param

netopyr

LGTM - thanks @kimbor

hedera-node/hedera-app/src/main/java/com/hedera/node/app/grpc/impl/MethodBase.java

netopyr

LGTM

* develop: chore: Extract key verification from HandleContext (#13937) feat: invalid query error handling (#13900) chore: add hapi test framework for dynamic address book transactions (#13874) docs: Add comment to explain `recId` and `v` fields of `EthTxData` (#13991) chore: refactor to use `ThrottleUsageSnapshot` (#13969) build: split publish of 'platform' and 'services' / do not publish blocknode (#14015) chore: 13980 remove get node info (#13982) feat: Reduce services-hedera's usage of PlatformContext (#13652) chore: Extract entity num generation from HandleContext (#13933) test: 013376- Add end to end tests for crypto create max auto associations (#13545) chore: Upgrade Netty to Latest Stable Release Version 4.1.110 (#13833) docs: Added design doc for Util Service (#13958) # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/flow/DispatchHandleContext.java

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

This reverts commit e9f0ecf.

…14085)

Initial commit

c214f24

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

kimbor added this to the v0.52 milestone Jun 17, 2024

kimbor self-assigned this Jun 17, 2024

kimbor marked this pull request as ready for review June 17, 2024 21:17

kimbor requested a review from a team June 17, 2024 21:17

kimbor requested review from a team as code owners June 17, 2024 21:17

kimbor requested review from rbair23, derektriley and acuarica June 17, 2024 21:17

kimbor added 2 commits June 17, 2024 14:18

Merge branch 'develop' into 13795-invalid-query-error-handling

17e1a92

Add test

6099032

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

netopyr requested changes Jun 18, 2024

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/query/QueryWorkflowImpl.java Outdated Show resolved Hide resolved

hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/query/QueryWorkflowImpl.java Outdated Show resolved Hide resolved

kimbor added 5 commits June 22, 2024 20:10

Merge branch 'develop' into 13795-invalid-query-error-handling

54905d7

Change to throw grpc error INVALID_ARGUMENT when query contains inval…

fe67518

…id param

Fix test

f26ebfe

Fix tests

82c5d70

Merge branch 'develop' into 13795-invalid-query-error-handling

a3ff066

netopyr previously approved these changes Jun 24, 2024

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/grpc/impl/MethodBase.java Show resolved Hide resolved

Update to log message

d7f60ad

kimbor dismissed netopyr’s stale review via d7f60ad June 24, 2024 18:55

netopyr approved these changes Jun 24, 2024

View reviewed changes

kimbor merged commit b5596c3 into develop Jun 24, 2024
40 checks passed

kimbor deleted the 13795-invalid-query-error-handling branch June 24, 2024 20:06

kimbor added a commit that referenced this pull request Jun 24, 2024

feat: invalid query error handling (#13900)

86a2ba4

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

kimbor mentioned this pull request Jun 24, 2024

feat: invalid query error handling (#13900) #14023

Merged

netopyr pushed a commit that referenced this pull request Jun 25, 2024

feat: invalid query error handling (#13900) (#14023)

e9f0ecf

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

iwsimon added a commit that referenced this pull request Jun 28, 2024

Revert "feat: invalid query error handling (#13900) (#14023)"

383e59b

This reverts commit e9f0ecf.

iwsimon added a commit that referenced this pull request Jun 28, 2024

chore: Revert "feat: invalid query error handling (#13900) (#14023)" (#…

5c89145

…14085)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: invalid query error handling #13900

feat: invalid query error handling #13900

kimbor commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

codecov bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

netopyr left a comment

netopyr left a comment

netopyr left a comment

feat: invalid query error handling #13900

feat: invalid query error handling #13900

Conversation

kimbor commented Jun 17, 2024 • edited Loading

github-actions bot commented Jun 17, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

codecov bot commented Jun 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jun 17, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

netopyr left a comment

Choose a reason for hiding this comment

netopyr left a comment

Choose a reason for hiding this comment

netopyr left a comment

Choose a reason for hiding this comment

kimbor commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

codecov bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading