Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (cherry pick) Enhance purechecks for CryptoCreateHandler (#12797) #13142

Merged
merged 2 commits into from
May 9, 2024
Merged

fix: (cherry pick) Enhance purechecks for CryptoCreateHandler (#12797) #13142

merged 2 commits into from
May 9, 2024

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

Cherry Pick of #12797 from 0.49 into develop

@thomas-swirlds-labs @Neeharika-Sompalli
feat: Enhance purechecks for CryptoCreateHandler (#12797)
5dcc4e2 
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team May 8, 2024 14:18
@thomas-swirlds-labs thomas-swirlds-labs requested review from a team as code owners May 8, 2024 14:18
@thomas-swirlds-labs thomas-swirlds-labs self-assigned this May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

2 tests   2 ✅  4m 59s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  6m 52s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

235 tests   234 ✅  22m 2s ⏱️
 17 suites    1 💤
 17 files      0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

459 tests   449 ✅  46m 44s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 50s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 15s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: Unit Test Results

  2 278 files  ±0    2 278 suites  ±0   1h 52m 36s ⏱️ - 1h 59m 55s
118 754 tests +2  118 687 ✅ +2  67 💤 ±0  0 ❌ ±0 
127 239 runs  +2  127 172 ✅ +2  67 💤 ±0  0 ❌ ±0 

Results for commit 690f9c1. ± Comparison against base commit 0ab8f3d.

This pull request removes 4016 and adds 3781 tests. Note that renamed tests count towards both. 

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8248d5a0
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@838423d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@9f66a844
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@56d1a143
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@eacc3a28
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@74ef918b
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@565b2af1
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

589 tests   589 ✅  1h 18m 45s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 690f9c1.

♻️ This comment has been updated with latest results.

netopyr
netopyr approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-swirlds-labs thomas-swirlds-labs merged commit c5061c0 into develop May 9, 2024
43 checks passed
@thomas-swirlds-labs thomas-swirlds-labs deleted the cherry-pick-12714-pureChecks-Create-to-develop branch May 9, 2024 14:33
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
@thomas-swirlds-labs @Neeharika-Sompalli @stoyanov-st
fix: (cherry pick) Enhance purechecks for CryptoCreateHandler (#12797) (
c66f4ea 
#13142)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netopyr netopyr netopyr approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23

@kimbor kimbor Awaiting requested review from kimbor kimbor was automatically assigned from hashgraph/hedera-services

@acuarica acuarica Awaiting requested review from acuarica acuarica was automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@thomas-swirlds-labs thomas-swirlds-labs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-swirlds-labs @netopyr