chore: Create a thorough unit test for KeyComparator #10753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsync-swirlds
commented
Jan 3, 2024
•
jsync-swirlds
commented
- Added KeyComparatorTest
- Added data-driven testing to exercise all probable input combinations.
- Adjusted KeyComparator to correctly order keys where testing showed errors.
- Adjusted one other unit test that depends on key ordering to match correct order.
Node: Unit Test Results 2 294 files + 1 2 294 suites +1 1h 0m 39s ⏱️ + 6m 26s Results for commit bd9e080. ± Comparison against base commit 8aeb2d6. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10753 +/- ##
=============================================
+ Coverage 62.80% 62.85% +0.05%
- Complexity 30970 31005 +35
=============================================
Files 3384 3384
Lines 136851 136851
Branches 14267 14264 -3
=============================================
+ Hits 85949 86020 +71
+ Misses 47488 47392 -96
- Partials 3414 3439 +25 ☔ View full report in Codecov by Sentry. |
jsync-swirlds
force-pushed
the
task-create-key-comparator-test
branch
from
919a0b4 to
8e3f18f
Compare
* Added KeyComparatorTest
* Added data-driven testing to exercise all probable input combinations.
* Adjusted KeyComparator to correctly order keys where testing showed errors.
* Adjusted one other unit test that depends on key ordering to match correct order.
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
jsync-swirlds
force-pushed
the
task-create-key-comparator-test
branch
from
8e3f18f to
bd9e080
Compare
tinker-michaelj
approved these changes
Jan 4, 2024
povolev15
pushed a commit
that referenced
this pull request
Jan 5, 2024
Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.