Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gradle to support Java 21 #10513

Merged
merged 15 commits into from
Dec 21, 2023
Merged

chore: update gradle to support Java 21 #10513

merged 15 commits into from
Dec 21, 2023

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Dec 14, 2023 •
edited by nathanklick
Loading

Description

  • Updated some dependent libraries version to support Java 21
  • Mockito.inline is no longer a standalone package but part of Mockito core
  • Mocking pre-exisiting class such as ByteBuffer caused many unit test fail, need to refactor some unit tests
Underlying exception : org.mockito.exceptions.base.MockitoException: Unsupported settings with this type 'java.nio.ByteBuffer'
	at org.mockito.junit.jupiter.MockitoExtension.beforeEach(MockitoExtension.java:160)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$2(TestMethodTestDescriptor.java:166)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$6(TestMethodTestDescriptor.java:202)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:202)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachCallbacks(TestMethodTestDescriptor.java:165)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:132)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:119)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:94)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:89)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:62)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at jdk.proxy2/jdk.proxy2.$Proxy5.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)
	Suppressed: java.lang.NullPointerException: Cannot invoke "java.util.Set.forEach(java.util.function.Consumer)" because the return value of "org.junit.jupiter.api.extension.ExtensionContext$Store.remove(Object, java.lang.Class)" is null
		at org.mockito.junit.jupiter.MockitoExtension.afterEach(MockitoExtension.java:194)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeAfterEachCallbacks$12(TestMethodTestDescriptor.java:260)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeAllAfterMethodsOrCallbacks$13(TestMethodTestDescriptor.java:276)
		at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeAllAfterMethodsOrCallbacks$14(TestMethodTestDescriptor.java:276)
		at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeAllAfterMethodsOrCallbacks(TestMethodTestDescriptor.java:275)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeAfterEachCallbacks(TestMethodTestDescriptor.java:259)
		at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:144)
		... 61 more
Caused by: org.mockito.exceptions.base.MockitoException: Unsupported settings with this type 'java.nio.ByteBuffer'
	at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:168)
	at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:399)
	at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:190)
	at net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:410)
	... 68 more

According to notes from Mockito github:

ByteBuffer is one of the classes that Mockito relies on internally for its behavior. 
Stubbing ByteBuffer will therefore lead to undefined behavior. Additionally, 
it is advised not to mock classes you don't own..

Test result

https://swirldslabs.slack.com/archives/C03G7CBJJ06/p1702607462099059

Related Issues

@JeffreyDallas JeffreyDallas requested review from a team as code owners December 14, 2023 17:12
@JeffreyDallas JeffreyDallas marked this pull request as draft December 14, 2023 17:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   17m 24s ⏱️ -12s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit b3136ec. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: HAPI Test (Token) Results

189 tests   189 ✔️  18m 29s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit b3136ec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: E2E Test Results

    1 files      1 suites   23m 34s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit b3136ec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 16s ⏱️
  2 suites  12 💤
  2 files      0 ❌

Results for commit b3136ec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: HAPI Test (Misc) Results

420 tests  ±0   347 ✔️ ±0   27m 55s ⏱️ -12s
  73 suites ±0     73 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit b3136ec. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 22s ⏱️ -10s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit b3136ec. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

412 tests   397 ✔️  52m 48s ⏱️
  55 suites    15 💤
  55 files        0 ❌

Results for commit b3136ec.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   53m 43s ⏱️ + 5m 41s
118 606 tests  - 1  118 571 ✔️  - 2  35 💤 +1  0 ❌ ±0 
127 023 runs   - 1  126 988 ✔️  - 2  35 💤 +1  0 ❌ ±0 

Results for commit b3136ec. ± Comparison against base commit 220fdba.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@220fdba). Click here to learn what that means.

❗ Current head 19bde83 differs from pull request most recent head b3136ec. Consider uploading reports for the commit b3136ec to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #10513   +/-   ##
==========================================
  Coverage           ?   63.02%           
  Complexity         ?    30851           
==========================================
  Files              ?     3363           
  Lines              ?   135618           
  Branches           ?    14121           
==========================================
  Hits               ?    85478           
  Misses             ?    46756           
  Partials           ?     3384

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffreyDallas JeffreyDallas marked this pull request as ready for review December 18, 2023 21:48
@JeffreyDallas JeffreyDallas requested review from a team as code owners December 18, 2023 21:48
@JeffreyDallas JeffreyDallas requested a review from a team December 18, 2023 21:48
@JeffreyDallas JeffreyDallas requested a review from a team as a code owner December 18, 2023 21:48
@JeffreyDallas @nathanklick
chore: gradle and java version change
7fd84b0 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas @nathanklick
Update kts
8357752 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
litt3
litt3 previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@litt3 litt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved WRT hashgraph owned file

cody-littley
cody-littley previously approved these changes Dec 21, 2023
View reviewed changes
timo0
timo0 previously approved these changes Dec 21, 2023
View reviewed changes
@JeffreyDallas
spot less
b3136ec 
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Neeharika-Sompalli
Neeharika-Sompalli approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

nathanklick
nathanklick requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@nathanklick nathanklick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying a temporary hold to prevent accidental merges until all other approvals have been received and the announcement with additional instructions has been sent out.

@nathanklick nathanklick merged commit 0f965a4 into develop Dec 21, 2023
42 checks passed
@nathanklick nathanklick deleted the 03838-D-gradle-update branch December 21, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes

@litt3 litt3 litt3 approved these changes

@cody-littley cody-littley cody-littley approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@artemananiev artemananiev artemananiev approved these changes

@OlegMazurov OlegMazurov OlegMazurov approved these changes

@nathanklick nathanklick nathanklick approved these changes

@imalygin imalygin imalygin approved these changes

@timo0 timo0 timo0 approved these changes

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera was automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

@poulok poulok Awaiting requested review from poulok poulok was automatically assigned from hashgraph/platform-hashgraph

@rbair23 rbair23 Awaiting requested review from rbair23

@thomas-swirlds-labs thomas-swirlds-labs Awaiting requested review from thomas-swirlds-labs thomas-swirlds-labs was automatically assigned from hashgraph/hedera-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update JRS CI pipelines to support Java 21 for executing tests Update CI pipelines to build using Java 21
10 participants
@JeffreyDallas @timo0 @imalygin @nathanklick @OlegMazurov @artemananiev @Neeharika-Sompalli @cody-littley @litt3 @anthony-swirldslabs