Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the pull request base branch as a fallback #10205

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Uses the pull request base branch as the fallback if there is not matching feature branch in the JRS repository.

Related Issues

@nathanklick nathanklick self-assigned this Nov 30, 2023
@nathanklick nathanklick requested review from a team as code owners November 30, 2023 20:54
Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  18m 21s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   47m 58s ⏱️ +26s
118 399 tests ±0  118 365 ✔️ ±0  34 💤 ±0  0 ±0 
126 771 runs  ±0  126 737 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit f0535c4. ± Comparison against base commit fe032d4.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@fe032d4). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10205   +/-   ##
==========================================
  Coverage           ?   63.17%           
  Complexity         ?    30706           
==========================================
  Files              ?     3328           
  Lines              ?   133945           
  Branches           ?    13881           
==========================================
  Hits               ?    84615           
  Misses             ?    45986           
  Partials           ?     3344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qnswirlds
qnswirlds previously approved these changes Nov 30, 2023
Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  20m 51s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: E2E Test Results

    1 files      1 suites   23m 0s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 47s ⏱️ - 1m 49s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit f0535c4. ± Comparison against base commit fe032d4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Misc) Results

419 tests   313 ✔️  25m 19s ⏱️
  73 suites  106 💤
  73 files        0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: Integration Test Results

279 tests   279 ✔️  29m 40s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Node: HAPI Test (Smart Contract) Results

411 tests   321 ✔️  44m 8s ⏱️
  56 suites    90 💤
  56 files        0

Results for commit f0535c4.

♻️ This comment has been updated with latest results.

Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick merged commit 282c61e into develop Dec 1, 2023
23 of 24 checks passed
@nathanklick nathanklick deleted the 10191-JRS-Use-Base-Branch branch December 1, 2023 17:40
mhess-swl pushed a commit that referenced this pull request Dec 4, 2023
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants