Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SCSC metrics from consensus node (that we can later get elsewhere) #16088

Open
Tracked by #15987
david-bakin-sl opened this issue Oct 22, 2024 · 0 comments · May be fixed by #16877
Open
Tracked by #15987

feat: SCSC metrics from consensus node (that we can later get elsewhere) #16088

david-bakin-sl opened this issue Oct 22, 2024 · 0 comments · May be fixed by #16877
Assignees
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Milestone

Comments

@david-bakin-sl
Copy link
Member

Start work on metrics we can get from consensus node until we can get them elsewhere.

First tranch should be:

  • System contract call counts, by method, by direct/proxy, by success/failure?
@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Oct 22, 2024
@david-bakin-sl david-bakin-sl self-assigned this Oct 22, 2024
@david-bakin-sl david-bakin-sl added this to the v0.57 milestone Oct 22, 2024
@david-bakin-sl david-bakin-sl moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Oct 22, 2024
@david-bakin-sl david-bakin-sl linked a pull request Dec 3, 2024 that will close this issue
2 tasks
david-bakin-sl added a commit that referenced this issue Dec 3, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus transactions and will show up int he record/block stream.)

Related issue(s):

Fixes #16088

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 5, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 6, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
@david-bakin-sl david-bakin-sl moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Dec 6, 2024
@Nana-EC Nana-EC modified the milestones: v0.57, v0.58 Dec 9, 2024
david-bakin-sl added a commit that referenced this issue Dec 11, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 11, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 12, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 12, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 17, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 17, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 17, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 20, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 20, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 20, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 20, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Dec 20, 2024
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Jan 9, 2025
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Jan 9, 2025
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
david-bakin-sl added a commit that referenced this issue Jan 9, 2025
These are the metrics that are interesting now and we can collect in the consensus node, but later we'll
collect in other ways. E.g., from block nodes. (All these metrics are for post-consensus
transactions and will show up in the record/block stream.)

Does _not_ include metrics for ExchangeRate and PNRG system contracts:  Those system contracts
are coded differently (don't use the same base (abstract) classes as HAS/HSS/HTS) and so will need
a bit more work.

Related issue(s):

Fixes #16088

Reviewer notes:

Changes a boatload of files.  Each of the ~60 FooTranslator classes (about one for each system
contract method) needs a small change, but that's a change to the construtor, and so it had
effects on all the unit tests for those classes as well.  You'll quickly see the pattern ...

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants