Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block-chain-bg.png does not show up in top navigation bar. #1568

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: block-chain-bg.png does not show up in top navigation bar. #1568

merged 1 commit into from
Dec 19, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 18, 2024

Description:

Trivial. Fix erroneous path for block-chain-bg.png in PageFrame.vue

Notes for reviewer:

Screenshot 2024-12-18 at 11 59 36

@svienot
Fix block-chain-bg.png in top navigation bar.
c1cd9fa 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.07% 24861 / 33560
🔵 Statements 74.07% 24861 / 33560
🔵 Functions 57.73% 948 / 1642
🔵 Branches 82.94% 4538 / 5471
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/page/PageFrame.vue 100% 100% 100% 100%
Generated in workflow #1530

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ericleponner
ericleponner approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@svienot svienot merged commit 55429d8 into main Dec 19, 2024
9 checks passed
@svienot svienot deleted the fix-block-chain-bg branch December 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner