chore: refactor ipfs config and metadata retrieval #1517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CoreConfig.ipfsGatewayUrlPrefix
toCoreConfig.ipfsGatewayURL
CoreConfig.ipfsGatewayURL = null
, the default value for this parameter remainshttps://gateway.pinata.cloud/ipfs/
for the time being.TokenMetadataAnalyzer
such that logic to retrieve assets from attributes values is a bit more modular and shared.Checklist