-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added ability to load spending plans from environment variable. #3153
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ebadiere <ebadiere@gmail.com>
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
Test Results 6 files - 14 82 suites - 201 28m 4s ⏱️ - 6m 31s Results for commit dba50bc. ± Comparison against base commit 9afe7c2. This pull request removes 380 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config suggestion, other than that looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few suggestions:
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
a7b302e
to
b79887a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a non-blocking clean up suggestion on the logic.
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/config/hbarSpendingPlanConfigService.spec.ts
Outdated
Show resolved
Hide resolved
…tent. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Cleaned up file and env var evaluation. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Flaky unit test fix. Signed-off-by: ebadiere <ebadiere@gmail.com> feat: Refactored implementation and updated tests. Signed-off-by: ebadiere <ebadiere@gmail.com>
54b6a01
to
4415cb3
Compare
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
…_CONFIG Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
==========================================
- Coverage 85.59% 85.57% -0.02%
==========================================
Files 48 48
Lines 3395 3398 +3
Branches 670 670
==========================================
+ Hits 2906 2908 +2
Misses 283 283
- Partials 206 207 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This enhancement adds the ability to load HBar Rate Limiter spending plans from an environment variable.
Related issue(s):
Fixes #3152
Checklist