-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip issue matching check for thirdparty build dependency librar… #2990
fix: Skip issue matching check for thirdparty build dependency librar… #2990
Conversation
…ies. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think we should allow these third-party PRs to skip the check_pr
CI task. Instead, we should let the CI fail for these PRs to serve as a reminder to update their labels and milestones.
… in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 1 nit can be addresed in future
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
- Coverage 89.54% 84.83% -4.71%
==========================================
Files 56 59 +3
Lines 3796 3937 +141
Branches 775 786 +11
==========================================
- Hits 3399 3340 -59
- Misses 350 357 +7
- Partials 47 240 +193
Flags with carried forward coverage won't be shown. Click here to find out more. |
#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com>
…82.0 (#3076) * fix: upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0 Snyk has created this PR to upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0. See this package in npm: @graphprotocol/graph-cli See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/24dd80bc-cab7-4d83-83d7-a604d57322e3?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Skip issue matching check for thirdparty build dependency librar… (#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: SDKClient timeouts are not getting logged with requestIds. (#3061) * fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Eric Badiere <ebadiere@gmail.com>
#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com>
…82.0 (#3076) * fix: upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0 Snyk has created this PR to upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0. See this package in npm: @graphprotocol/graph-cli See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/24dd80bc-cab7-4d83-83d7-a604d57322e3?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Skip issue matching check for thirdparty build dependency librar… (#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: SDKClient timeouts are not getting logged with requestIds. (#3061) * fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Eric Badiere <ebadiere@gmail.com>
Skip issue check for thirdparty libraries. We do not control them.
Related issue(s):
Fixes #2988