fix: reworked gas comparison logic #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC and
a team
as code owners
|
quiet-node
deleted the
2610-basefeepergas-is-compared-to-a-hard-coded-value-in-batch-1-acceptance-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reworks gas comparison logic. Originally, gas price was compared to a hard-coded value, 71 HBARs, which is only true if the environment is local-net or previewnet. The new logic retrieves the expected gas value from the Relay for the comparison so it would be correct in all environments.
Related issue(s):
Fixes #2610
Notes for reviewer:
Checklist