Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2561 release automation cannot find npm #2564

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

ebadiere
Copy link
Collaborator

@ebadiere ebadiere commented Jun 4, 2024

Applied the Node.js install right before the npm ci.

Related issue(s):

Fixes #2561

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere requested review from AlfredoG87, Nana-EC and a team as code owners June 4, 2024 15:47
@ebadiere ebadiere self-assigned this Jun 4, 2024
@ebadiere ebadiere added the bug Something isn't working label Jun 4, 2024
@ebadiere ebadiere added this to the 0.49.0 milestone Jun 4, 2024
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rbarkerSL rbarkerSL changed the title 2561 release automation cannot find npm fix: 2561 release automation cannot find npm Jun 4, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jun 4, 2024

Tests

    2 files  150 suites   13s ⏱️
838 tests 837 ✔️ 1 💤 0
850 runs  849 ✔️ 1 💤 0

Results for commit 4a77d0f.

Copy link

github-actions bot commented Jun 4, 2024

Acceptance Tests

  19 files  252 suites   34m 15s ⏱️
601 tests 593 ✔️ 3 💤 5
829 runs  819 ✔️ 5 💤 5

Results for commit 4a77d0f.

@rbarkerSL rbarkerSL merged commit 496722a into main Jun 4, 2024
36 of 37 checks passed
@rbarkerSL rbarkerSL deleted the 2561-release-automation-cannot-find-npm branch June 4, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The release automation cannot find the npm binary
2 participants