Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve issue with failing acceptance batch 1 test #2546

Merged
merged 4 commits into from
May 31, 2024

Conversation

Ivo-Yankov
Copy link
Collaborator

Description:
Fixes the failing test should delete the file created while execute "eth_sendRawTransaction" to deploy a large contract that was preventing other PRs from being merged

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
@Ivo-Yankov Ivo-Yankov added bug Something isn't working limechain labels May 29, 2024
@Ivo-Yankov Ivo-Yankov added this to the 0.49.0 milestone May 29, 2024
@Ivo-Yankov Ivo-Yankov self-assigned this May 29, 2024
@Ivo-Yankov Ivo-Yankov linked an issue May 29, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 29, 2024

Tests

    2 files  149 suites   14s ⏱️
833 tests 832 ✔️ 1 💤 0
845 runs  844 ✔️ 1 💤 0

Results for commit d73d26f.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
27.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented May 29, 2024

Acceptance Tests

     27 files     423 suites   44m 6s ⏱️
   593 tests    584 ✔️   3 💤   6
1 587 runs  1 551 ✔️ 21 💤 15

Results for commit d73d26f.

♻️ This comment has been updated with latest results.

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ivo-Yankov Ivo-Yankov merged commit a0e762f into main May 31, 2024
35 checks passed
@Ivo-Yankov Ivo-Yankov deleted the 2545-fix-failing-test-in-acceptance-batch-1 branch May 31, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix failing test in Acceptance Batch 1
2 participants