Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updated ci pipelines for security and best practices #2535

Merged

Conversation

rbarkerSL
Copy link
Contributor

Description:

Updated .github/workflows to conform with best CI practices and to align with security needs.

Related issue(s):

Fixes #2531

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL self-assigned this May 24, 2024
@rbarkerSL rbarkerSL requested a review from a team as a code owner May 24, 2024 02:50
@rbarkerSL rbarkerSL linked an issue May 24, 2024 that may be closed by this pull request
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL marked this pull request as draft May 24, 2024 19:33
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

github-actions bot commented May 24, 2024

Tests

    2 files  149 suites   13s ⏱️
833 tests 832 ✔️ 1 💤 0
845 runs  844 ✔️ 1 💤 0

Results for commit 82105dc.

♻️ This comment has been updated with latest results.

@rbarkerSL rbarkerSL marked this pull request as ready for review May 28, 2024 13:48
Nana-EC
Nana-EC previously approved these changes May 28, 2024
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

github-actions bot commented May 28, 2024

Acceptance Tests

     24 files     352 suites   37m 34s ⏱️
   594 tests    585 ✔️   3 💤   6
1 236 runs  1 208 ✔️ 15 💤 13

Results for commit 82105dc.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes May 28, 2024
@quiet-node quiet-node added the dependencies Pull requests that update a dependency file label May 28, 2024
@quiet-node quiet-node added this to the 0.49.0 milestone May 28, 2024
@quiet-node quiet-node changed the title ci: 2531 update ci pipelines for security and best practices ci: updated ci pipelines for security and best practices May 28, 2024
…0 minutes

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rbarkerSL rbarkerSL requested a review from Nana-EC May 28, 2024 18:49
@rbarkerSL rbarkerSL merged commit e8b8359 into main May 28, 2024
35 checks passed
@rbarkerSL rbarkerSL deleted the 2531-update-ci-pipelines-for-security-and-best-practices branch May 28, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI pipelines for security and best practices
3 participants